Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove strapi-server file from generate plugin #50

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

alexandrebodin
Copy link
Member

What does it do?

Describe the technical changes you did.

Why is it needed?

Once strapi/strapi#21194 is merged and released, plugins won't need a mandatory strapi-server.js file

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 81f0998

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@strapi/sdk-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexandrebodin alexandrebodin added pr: enhancement Refactorings / perfs / testing / translations source: sdk-plugin labels Sep 9, 2024
Signed-off-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
Copy link
Collaborator

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's not merge until we actually release the RC that can handle this just to be safe

@innerdvations innerdvations merged commit 08d2f73 into main Sep 10, 2024
2 checks passed
@innerdvations innerdvations deleted the chore/remove-strapi-server branch September 10, 2024 07:45
@echoes-hq echoes-hq bot added the echoes: enhancement Extensions to existing functionality, tests, tools and features label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: enhancement Extensions to existing functionality, tests, tools and features pr: enhancement Refactorings / perfs / testing / translations source: sdk-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants